[ 
https://issues.apache.org/jira/browse/MAHOUT-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054897#comment-13054897
 ] 

Sean Owen commented on MAHOUT-740:
----------------------------------

I just mean that the current MySQL class is really what should be called SQL92 
-- and then push that call to getFetchSize() down into a subclass called MySQL. 
It just avoids some of the copy-and-paste here. In the end, you have the same 
classes with same behavior.

> add SQL92JDBCItemSimilarity
> ---------------------------
>
>                 Key: MAHOUT-740
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-740
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Collaborative Filtering
>    Affects Versions: 0.6
>            Reporter: Daniel Xiaodan Zhou
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: SQL92.patch
>
>
> I'm thinking to add 
> org.apache.mahout.cf.taste.impl.similarity.jdbc.SQL92JDBCItemSimilarity. It 
> would directly extends AbstractJDBCItemSimilarity. Lots of code would be 
> copied from MySQLJDBCItemSimilarity.
> Any comments/suggestions before I starts the patch?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to