[
https://issues.apache.org/jira/browse/MAHOUT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055693#comment-13055693
]
Sean Owen commented on MAHOUT-734:
----------------------------------
OK, I'll commit with some style changes.
We don't put final on locals -- just clutters the code too much.
There were a number of whitespace-only changes here; I'd omit those.
You want to close() streams in a finally block.
Tiny stuff -- we don't use * imports, and "new Date().getTime()" is best as
"System.currentTimeMillis()".
As a "bonus" I saw a pre-existing problem in HmmModel.clone() and just fixed it
along the way. (Calling super.clone() and ignoring the value doesn't make
sense.)
I wonder if your "lossy" serializer should just be the default Writable
implementation for HmmModel?
> Command-line utils for HMM
> --------------------------
>
> Key: MAHOUT-734
> URL: https://issues.apache.org/jira/browse/MAHOUT-734
> Project: Mahout
> Issue Type: New Feature
> Components: Classification
> Affects Versions: 0.5
> Reporter: Sergey Bartunov
> Priority: Minor
> Labels: hmm
> Fix For: 0.6
>
> Attachments: hmm-utils.patch
>
>
> Mahout already have HMM functionality, but it presents only in API.
> Command-line tools should be added and registered in driver.classes.props
> These patches are get from git against trunk of mahout's github
> [this is my "traning" issue in Jira to learn how to commit patches to the
> Mahout, so please be merficul]
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
