On Nov 5, 2011, at 4:16 AM, Sean Owen wrote: > Yeah, the intent was to reuse all the code in AbstractJob. This splits > up the support. I'd prefer to go all the way if you're doing this and > keep all the job standardization in one place. >
That's fine, I just didn't want to have to go chase down a whole bunch of replacements by moving to the statics just yet (I'm on a fairly tight time deadline). FWIW, it seems really odd to me that something like prepareJob isn't simply a part of Hadoop. > On Sat, Nov 5, 2011 at 12:42 AM, Grant Ingersoll <[email protected]> wrote: >> I've moved some of the AbstractJob.prepareJob functionality over to statics >> in HadoopUtil so that non AbstractJob's can take advantage. The calls in >> AbstractJob now use HadoopUtil. >> >> We have a ton of places where we can replace a lot of repetitive code with >> HadoopUtil.prepareJob(). >> >> Cheers, >> Grant
