[ 
https://issues.apache.org/jira/browse/MAHOUT-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162901#comment-13162901
 ] 

Sean Owen commented on MAHOUT-910:
----------------------------------

I agree. Since we have three samplings here, the simplest thing is to expose 
three settings to control each of them individually.
Right now one setting is exposed, as two numbers. I could just clone (and 
rename) that pair of parameters so that they can be tuned individually. I could 
keep the 2-arg constructor and have it set all 3 pairs of parameters to the 
single pair given, to preserve a bit of backward-compatibility. (Behavior is 
still quite different though.)

I think we can endlessly add hook after hook and strategy inside strategies; at 
some point I'd probably say it's easier for you to maintain your own copy with 
particular behavior changes if you really need to. At least it'd be better to 
see it's opening up support for a broad class of use cases.
                
> Improve sampling in SamplingCandidateItemStrategy, optimize intersection 
> computations
> -------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-910
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-910
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.5
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>             Fix For: 0.6
>
>         Attachments: MAHOUT-910.patch, MAHOUT-910.patch
>
>
> Per the lengthy discussion on the mailing list about optimizing 
> SamplingCandidateItemStrategy and related code, I'm opening this placeholder 
> issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to