[ 
https://issues.apache.org/jira/browse/MAHOUT-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162984#comment-13162984
 ] 

Jeff Eastman commented on MAHOUT-843:
-------------------------------------

The wiki page looks like a good start. If you could include an example using 
the post processor it would help others to understand how to use it.

The driver run() method adds -i and -o options but does not add the -xm option 

addOption(DefaultOptionCreator.methodOption().create());

thus the subsequent getOption(DefaultOptionCreator.METHOD_OPTION) will always 
return null and sequential execution cannot be enabled. 

I'd like to see all the public methods, at least, have useful JavaDocs. When I 
look at the ClusterOutputPostProcessorDriver, there are several methods with 
incomplete JavaDoc comments. The 3 TODO indicators are a place to start, but 
many of the other methods in the patch do not include descriptions of the 
method arguments. In Eclipse, and I guess in IntelliJ, you can have the IDE 
flag these situations.

The k-means unit test which is failing is testKMeansWithCanopyClusterId, which 
fails because it is looking for "clusters-0" and not "clusters-0-final". There 
are also other unit tests which fail for the same reasons. I can fix them all 
before I commit the patch, but have you considered doing your development in a 
Linux VM on your Windows box? It is good practice to always run a full clean 
build before committing, since little changes like "-final" have a way of 
breaking lots of other code. 
                
> Top Down Clustering
> -------------------
>
>                 Key: MAHOUT-843
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-843
>             Project: Mahout
>          Issue Type: New Feature
>          Components: Clustering
>    Affects Versions: 0.6
>            Reporter: Paritosh Ranjan
>            Assignee: Jeff Eastman
>              Labels: clustering, patch
>             Fix For: 0.6
>
>         Attachments: MAHOUT-843-patch, MAHOUT-843-patch-only-postprocessor, 
> MAHOUT-843-patch-only-postprocessor-v1, 
> MAHOUT-843-patch-only-postprocessor-v2, 
> MAHOUT-843-patch-only-postprocessor-v3, 
> MAHOUT-843-patch-only-postprocessor-v4, 
> MAHOUT-843-patch-only-postprocessor-v5, MAHOUT-843-patch-v1, 
> Top-Down-Clustering-patch
>
>
> Top Down Clustering works in multiple steps. The first step is to find 
> comparative bigger clusters. The second step is to cluster the bigger chunks 
> into meaningful clusters. This can performance while clustering big amount of 
> data. And, it also removes the dependency of providing input clusters/numbers 
> to the clustering algorithm.
> The "big" is a relative term, as well as the smaller "meaningful" terms. So, 
> the control of this "bigger" and "smaller/meaningful" clusters will be 
> controlled by the user.
> Which clustering algorithm to be used in the top level and which to use in 
> the bottom level can also be selected by the user. Initially, it can be done 
> for only one/few clustering algorithms, and later, option can be provided to 
> use all the algorithms ( which suits the case ). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to