[
https://issues.apache.org/jira/browse/MAHOUT-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164561#comment-13164561
]
Ted Dunning commented on MAHOUT-918:
------------------------------------
Can you post this as a review board review. There are lots of comments to be
made.
At a high level, I note the following issues:
1) I don't see a design document. You cite a few articles but you don't say
what you are really doing.
2) Is map-reduce an appropriate approach here for model averaging?
3) How do you plan to deal with randomization of data order?
4) There are a number of style issues:
a) you have loops that look like this:
{code}
for (...) {
if (something) {
... stuff ...
continue;
}
... other stuff ...
break;
}
{code}
This is slightly perverse and is akin to using goto statements. Much better is
this:
{code}
for (...) {
if (something) {
... stuff ...
} else {
... other stuff ...
break;
}
}
{code}
> Implement SGD based classifiers using MapReduce
> -----------------------------------------------
>
> Key: MAHOUT-918
> URL: https://issues.apache.org/jira/browse/MAHOUT-918
> Project: Mahout
> Issue Type: New Feature
> Components: Classification
> Affects Versions: 0.6
> Reporter: issei yoshida
> Attachments: MAHOUT-918.patch
>
>
> Implement SGD based classifiers (Logistic Regression, Adaptive Logistic
> regression and Passive-Aggressive) using MapReduce.
> They are implemented using Iterative Parameter Mixtures algorithm which is
> referred to in the following papers.
> http://research.google.com/pubs/pub36948.html
> http://aclweb.org/anthology-new/N/N10/N10-1069.pdf
> http://books.nips.cc/papers/files/nips22/NIPS2009_0345.pdf
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
