----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3147/#review3866 -----------------------------------------------------------
/trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixRowMeanJob.java <https://reviews.apache.org/r/3147/#comment8690> can be private static final /trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixRowMeanJob.java <https://reviews.apache.org/r/3147/#comment8691> No need to clone here, see org.apache.mahout.common.mapreduce.VectorSumReducer - Sebastian On 2011-12-13 00:10:57, Raphael Cendrillon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3147/ > ----------------------------------------------------------- > > (Updated 2011-12-13 00:10:57) > > > Review request for mahout and Dmitriy Lyubimov. > > > Summary > ------- > > Here's a patch with a simple job to calculate the row mean (column-wise > mean). One outstanding issue is the combiner, this requires a wrtiable class > IntVectorTupleWritable, where the Int stores the number of rows, and the > Vector stores the column-wise sum. > > > This addresses bug MAHOUT-923. > https://issues.apache.org/jira/browse/MAHOUT-923 > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/mahout/math/hadoop/DistributedRowMatrix.java > 1213474 > > /trunk/core/src/main/java/org/apache/mahout/math/hadoop/MatrixRowMeanJob.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/mahout/math/hadoop/TestDistributedRowMatrix.java > 1213474 > > Diff: https://reviews.apache.org/r/3147/diff > > > Testing > ------- > > Junit test > > > Thanks, > > Raphael > >
