[ 
https://issues.apache.org/jira/browse/MAHOUT-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205392#comment-13205392
 ] 

Grant Ingersoll commented on MAHOUT-947:
----------------------------------------

Hmm, should be a getOptions in there, but maybe my patch is messed up:
{code}
/**
   * Options can occur multiple times, so return the list
   * @param optionName The unadorned (no "--" prefixing it) option name
   * @return The values, else null.  If the option is present, but has no 
values, then the result will be an empty list (Collections.emptyList())
   */
  public List<String> getOptions(String optionName){
    return argMap.get(keyFor(optionName));
  }
{code}

Or do you mean we should just have one or the other, but not both?  That could 
work.  I did both as it seems like one knows when one only wants want arg and 
when one wants multiples, so getOption() is really just a convenience method.

Perhaps the parsedArgs is still useful if one wants to iterate over them or 
something?  There also is at least one place where we use them to pass through 
to other jobs that aren't necessarily AbstractJobs 
(DistributedConjugateGradientSolver)

                
> Improvements to seqdumper
> -------------------------
>
>                 Key: MAHOUT-947
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-947
>             Project: Mahout
>          Issue Type: Improvement
>            Reporter: tom pierce
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: MAHOUT-947-2.patch, MAHOUT-947.patch, MAHOUT-947.patch, 
> MAHOUT-947.patch
>
>
> I've put together a few handy additions to seqdumper:
> * Ability to dump all sequence files in a directory.
> * A quiet flag to attenuate the non-data output.
> * A flag to toggle name-only printing for NamedVector values.
> * An option to only print the N highest-valued elements in WeightedVector 
> values
> Seems like others will probably find some of these to be helpful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to