[ https://issues.apache.org/jira/browse/MAHOUT-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217952#comment-13217952 ]
Saikat Kanjilal commented on MAHOUT-929: ---------------------------------------- Paritosh, Some more questions after I read through your code inside ClusterClassificationDriverTest: 1) it seems that the map-reduce method you added called testVectorClassificationWithOutlierRemovalMR only differs from testVectorClassificationWithOutlierRemoval by the following line: HadoopUtil.delete(conf, classifiedOutputPath); 2) I was going to add the following test cases inside ClusterClassificationDriverTest (I chose not to add ClusterClassificationMapperTest): - testVectorClassificationWithoutOutlierRemovalMR - testVectorClassificationWithoutOutlierRemovalChangeThresholdMR - testVectorClassificationWithoutOutlierRemovalChangeThreshold (pass in some custom threshold here and mock out expectations) Finally I may add some edge error cases surrounding the above Thoughts, let me know if you think of other cases to add. I want to first spend some time learning this in more detail before diving into the kmeans driver rework. > Refactor Clustering (Vector Classification) into a Separate Postprocess with > Outlier Pruning > -------------------------------------------------------------------------------------------- > > Key: MAHOUT-929 > URL: https://issues.apache.org/jira/browse/MAHOUT-929 > Project: Mahout > Issue Type: Improvement > Components: Classification, Clustering > Affects Versions: 0.6 > Reporter: Jeff Eastman > Assignee: Paritosh Ranjan > Fix For: 0.7 > > Attachments: Mahout-929, Mahout-929, Mahout-929, Mahout-929 > > > The current clustering drivers have a -cp option to produce clusteredPoints > directory containing the input vectors classified by the final clusters > produced by the algorithm. These options are redundantly implemented in those > drivers. > - Factor out & implement an independent post processor to perform the > classification step independently of the various clustering implementations. > - Implement a pluggable outlier removal capability for this classifier. > - Consider building off of the ClusterClassifier & ClusterIterator ideas. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira