----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4237/#review5754 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/mahout/common/HadoopUtil.java <https://reviews.apache.org/r/4237/#comment12516> Extra white spaces generate style warnings but are notoriously hard to eliminate. I have no problems with them but it was a subject of review notes from other committers before, I am just reproducing collective mind here. trunk/core/src/main/java/org/apache/mahout/common/HadoopUtil.java <https://reviews.apache.org/r/4237/#comment12518> is this really an issue with Hadoop 0.20.203? i don't think we care about classic hadoop 0.20.2 anymore. trunk/core/src/test/java/org/apache/mahout/clustering/meanshift/TestMeanShift.java <https://reviews.apache.org/r/4237/#comment12552> This and some other changes look suspiciously like a functional change rather than a hadoop compatibility change. I think it would help somebody else more familiar with this code to assure it is indeed benign.. - Dmitriy On 2012-03-08 01:24:21, tom pierce wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4237/ > ----------------------------------------------------------- > > (Updated 2012-03-08 01:24:21) > > > Review request for mahout and Dmitriy Lyubimov. > > > Summary > ------- > > This is the current patch for MAHOUT-822 (as posted by Bilung Lee). > > > This addresses bug MAHOUT-822. > https://issues.apache.org/jira/browse/MAHOUT-822 > > > Diffs > ----- > > trunk/core/pom.xml 1296318 > trunk/core/src/main/java/org/apache/mahout/common/HadoopUtil.java 1296318 > > trunk/core/src/test/java/org/apache/mahout/classifier/df/mapreduce/partial/MockContext.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/classifier/df/mapreduce/partial/PartialSequentialBuilder.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/classifier/df/mapreduce/partial/Step1MapperTest.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/clustering/canopy/TestCanopyCreation.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/clustering/classify/ClusterClassificationDriverTest.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/clustering/kmeans/TestKmeansClustering.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/clustering/meanshift/TestMeanShift.java > 1296318 > trunk/core/src/test/java/org/apache/mahout/common/DummyCounter.java 1296318 > trunk/core/src/test/java/org/apache/mahout/common/DummyRecordWriter.java > 1296318 > trunk/core/src/test/java/org/apache/mahout/common/DummyStatusReporter.java > 1296318 > > trunk/core/src/test/java/org/apache/mahout/math/hadoop/TestDistributedRowMatrix.java > 1296318 > > trunk/integration/src/test/java/org/apache/mahout/clustering/TestClusterDumper.java > 1296318 > trunk/pom.xml 1296318 > > Diff: https://reviews.apache.org/r/4237/diff > > > Testing > ------- > > Passes unit tests under default config as well as under hadoop 0.23.1. > > > Thanks, > > tom > >
