----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4632/#review7247 -----------------------------------------------------------
Looks good aside from the one issue below. trunk/bin/mahout <https://reviews.apache.org/r/4632/#comment16017> Think we need to omit HADOOP_BINARY_CLASSPATH here; otherwise I get an error due to my cluster and Mahout HDFS libs having different API versions when I run with MAHOUT_LOCAL set. - tom On 2012-04-04 00:26:36, Roman Shaposhnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4632/ > ----------------------------------------------------------- > > (Updated 2012-04-04 00:26:36) > > > Review request for mahout and tom pierce. > > > Summary > ------- > > Patch according to the JIRA discussion. > > > This addresses bug MAHOUT-994. > https://issues.apache.org/jira/browse/MAHOUT-994 > > > Diffs > ----- > > trunk/bin/mahout 1309189 > trunk/distribution/src/main/assembly/bin.xml 1309189 > > Diff: https://reviews.apache.org/r/4632/diff > > > Testing > ------- > > build and execution in various modes > > > Thanks, > > Roman > >
