Good comments. I addressed some of them, some I side-stepped (for which I am now famously embarrassed @pbrane!)
On Wed, May 2, 2012 at 12:27 PM, Robin Anil <[email protected]> wrote: > My comments are put inline. Except the fact that the code is complex and > hard to read (which the original code was from the start), I don't see any > issues in committing. > ------ > Robin Anil > > > On Wed, May 2, 2012 at 2:18 PM, Robin Anil <[email protected]> wrote: > > > Nice. I am putting comments inline. I am hoping you can see them > realtime. > > ------ > > Robin Anil > > > > > > > > On Wed, May 2, 2012 at 2:00 PM, Ted Dunning <[email protected]> > wrote: > > > >> See > >> > >> > >> > https://github.com/tdunning/mahout/commit/5750e1439d6afe75724c3f5d40ca0eca0e337b55 > >> > >> and > >> > >> > >> > https://github.com/tdunning/mahout/commit/0c40be5525e90ec5066947cc172f6b51c52b00fd > >> > >> > >> On Wed, May 2, 2012 at 11:43 AM, Robin Anil <[email protected]> > wrote: > >> > >> > Its really hard to read a patch. Is there an easy way to view the diff > >> > against SVN tree and review? > >> > ------ > >> > Robin Anil > >> > > >> > > >> > On Wed, May 2, 2012 at 1:30 PM, Ted Dunning <[email protected]> > >> wrote: > >> > > >> > > Any comments on MAHOUT-1005? > >> > > > >> > > https://issues.apache.org/jira/browse/MAHOUT-1005 > >> > > > >> > > I am planning on committing it shortly if not, but it is a big patch > >> > (over > >> > > a dozen files deleted, hundreds to thousands of lines of new code) > >> > > > >> > > >> > > > > >
