[ 
https://issues.apache.org/jira/browse/MAHOUT-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270786#comment-13270786
 ] 

Suneel Marthi edited comment on MAHOUT-979 at 5/8/12 8:13 PM:
--------------------------------------------------------------

Thanks for this Sebastian, see that you had modified the patch and cleaned up 
my code.

There are 2 unused imports in RowSimilarityJob.java that I had introduced and 
should have been taken out, could you take care of that.
                
      was (Author: smarthi):
    Uploading a patch again, may be the final one.

1. Removed unused imports in RowSimilarityJob.java
2. Fixed code indentation in AbstractJob.java for the new method 
getDimensions() that was added as part of this patch.  
                  
> RowSimilarityJob should be able to infer the number of columns from the input 
> matrix if not specified 
> ------------------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-979
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-979
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Math
>    Affects Versions: 0.6, 0.7
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>              Labels: mahout
>             Fix For: 0.7
>
>         Attachments: Mahout-979.patch, Mahout-979.patch
>
>
> Presently RowSimilarityJob expects to be provided the 'numberOfColumns' (-r) 
> by the user and this is not an optional argument. If this is not specified 
> explicitly RowSimilarityJob should be able to get the number of columns by 
> the vector size. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to