Robert Jäschke created MAHOUT-1015:
--------------------------------------

             Summary: Precondition check in IRStatisticsImpl broken
                 Key: MAHOUT-1015
                 URL: https://issues.apache.org/jira/browse/MAHOUT-1015
             Project: Mahout
          Issue Type: Bug
          Components: Collaborative Filtering
    Affects Versions: 1.0
            Reporter: Robert Jäschke
            Assignee: Sean Owen
            Priority: Minor


The precondition check in the constructor of 
org.apache.mahout.cf.taste.impl.eval.IRStatisticsImpl includes Copy&Paste 
errors:

Preconditions.checkArgument(fallOut >= 0.0 && fallOut <= 1.0, "Illegal fallOut: 
" + fallOut);
Preconditions.checkArgument(fallOut >= 0.0 && fallOut <= 1.0, "Illegal nDCG: " 
+ ndcg);
Preconditions.checkArgument(reach >= 0.0 && reach <= 1.0, "Illegal reach: " + 
ndcg);

The second line shows a message for nDCG but checks the fallOut, the third line 
checks the reach but prints out the nDCG.

This error is also in the current version from the SVN 
(http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/IRStatisticsImpl.java?revision=1213930&view=markup)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to