On Wed, Jul 4, 2012 at 8:43 PM, Dawid Weiss <[email protected]> wrote: >> - introduce the RandomTestRunner > > Awesome :)
Yeah - I really liked what I saw in Poznan. >> - fix all issues that bubbled up as a result (I ran into quite a few problems >> due to threads not being shut down either as part of the test (not too >> critical) >> or even during regular computation - happy to isolate what I ran into here >> and >> file separate issues (including fixes obviously) for each of these. > > You can always mark the superclass with: > > @ThreadLeaks(failTestIfLeaking = false) Jepp, I know that one. However in my case I really wanted them to fail as there were a few issues with executor pools being left open etc. - so having that part did help. > For the most part thread leaks should be handled gracefully but there > are situations in which recovery from a thread leak is hard. I'm > currently fighting the subject in the Lucene land and I expect a few > refactorings to take place -- hope it's not going to be problematic > for you. If you have any questions or problems -- fire at me directly > (don't want to miss something on the list). Will certainly do! >> - mark all long running tests with the nightly annotation - my goal here is >> not >> to switch them off forever but rather draw contributors' attention to those >> running particularly long (>20s) and fix them > > You can also design your own thread group and disable it by default. Look at: > > LuceneTestCase.@Slow > > annotation -- I just recently marked a lot of tests as slow. They can > be bulk enabled or disabled with a system property. Awesome. Thanks for pointing that out. Isabel
