[
https://issues.apache.org/jira/browse/MAHOUT-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466137#comment-13466137
]
Hudson commented on MAHOUT-1083:
--------------------------------
Integrated in Mahout-Quality #1678 (See
[https://builds.apache.org/job/Mahout-Quality/1678/])
MAHOUT-1083:
- committed patch to CIReducer that was producing odd results
- changed test count from 3 to 4 to cause mean shift test to pass
- all tests now run again (Revision 1391752)
Result = SUCCESS
jeastman :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391752
Files :
*
/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/iterator/CIReducer.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/iterator/ClusterWritable.java
*
/mahout/trunk/core/src/test/java/org/apache/mahout/clustering/meanshift/TestMeanShift.java
> CIReducer in kmeans doesn't work well
> -------------------------------------
>
> Key: MAHOUT-1083
> URL: https://issues.apache.org/jira/browse/MAHOUT-1083
> Project: Mahout
> Issue Type: Bug
> Environment: hadoop-2.0.0-alpha: pseudo cluster and single node
> cluster hadoop-1.0.3: pseudo cluster hadoop-0.20.2:pseudo cluster
> mahout: mahout-0.7 os: ubuntu 11.04 jdk: jdk1.6.0_27
> Reporter: liutengfei
> Attachments: MAHOUT-1083.patch
>
>
> the function "reduce" in mahout-0.7-kmeans-CIReducer.java doesn't work well
> as it looks like.
> protected void reduce(IntWritable key, Iterable<ClusterWritable> values,
> Context context) throws IOException,
> InterruptedException {
> Iterator<ClusterWritable> iter = values.iterator();
> ClusterWritable first = null;
> while (iter.hasNext()) {
> ClusterWritable cw = iter.next();
> if (first == null) {
> first = cw;
> } else {
> first.getValue().observe(cw.getValue());
> }
> }
> List<Cluster> models = new ArrayList<Cluster>();
> models.add(first.getValue());
> classifier = new ClusterClassifier(models, policy);
> classifier.close();
> context.write(key, first);
> }
> Apparently， the variable "first" will collect all output data of maps.
> Actually but, the value of "first" will change after the code
> "ClusterWritable cw = iter.next();", same with this new variable "cw"! I
> don't why but running result shows that the code runs looks like
> this:"ClusterWritable cw = first = iter.next();".
> is "cw" a reference a to "iter"?
> is "iter.next" just change the value of "iter" itself to the next?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
