This actually sounds pretty good, at least in advance of actually looking at the code.
On Fri, Oct 12, 2012 at 2:15 AM, Sean Owen <[email protected]> wrote: > (Bug fixes are good, if you can separate those out, those should not > be controversial.) > > I am still skeptical of new blobs of code, as these have been a big > problem for the project. If it's clean, follows existing code and > APIs, and you are willing to actively support it, it may be > un-harmful. > > I am not going to be able to work on Mahout in any significant way any > more, so would not feel right committing this myself, especially if > the expectation was that I would be able to help modify and support > these changes. But, leave it to other committers to take that up. It > sounds lik eyou have made a lot of effort to weave it in nicely. > > > > Now it is integrable to Mahout, and can work with Mahout's existing > > Recommender interface. It does not modify any existing code, except a > couple > > of additional lines in driver.class.props, which define a few commandline > > utilities I find useful while experimenting a recommender. >
