[
https://issues.apache.org/jira/browse/MAHOUT-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594848#comment-13594848
]
Ted Dunning commented on MAHOUT-1151:
-------------------------------------
Regarding the patch, it is mostly quite good. Two small issues that I see are:
1) using a float for the threshold probably just slows the code down due to
conversions from double. I only use floats where there is a big win
2) more importantly, it doesn't appear from the patch that there is any
trimming of the result list in the loop. This is important to do because that
causes the threshold to increase and the insertion of items to become more and
more rare.
> Object reuse in distributed ALS
> -------------------------------
>
> Key: MAHOUT-1151
> URL: https://issues.apache.org/jira/browse/MAHOUT-1151
> Project: Mahout
> Issue Type: Improvement
> Components: Collaborative Filtering
> Affects Versions: 0.8
> Reporter: Sebastian Schelter
> Assignee: Sebastian Schelter
> Attachments: MAHOUT-1151.patch
>
>
> In order to improve the performance our distributed ALS code, we should try
> to avoid object instantiation as much as possible, especially when it is done
> per input tuple.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
