[ 
https://issues.apache.org/jira/browse/MAHOUT-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599017#comment-13599017
 ] 

Hudson commented on MAHOUT-1144:
--------------------------------

Integrated in Mahout-Quality #1896 (See 
[https://builds.apache.org/job/Mahout-Quality/1896/])
    MAHOUT-1144 fix SVD++ normalization (Revision 1455212)

     Result = SUCCESS
srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1455212
Files : 
* 
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/svd/SVDPlusPlusFactorizer.java

                
> Wrong normalization in SVD++
> ----------------------------
>
>                 Key: MAHOUT-1144
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1144
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering
>    Affects Versions: 0.7
>            Reporter: Sebastian Schelter
>            Assignee: Sebastian Schelter
>              Labels: svd, svd++
>             Fix For: 0.8
>
>
> Reported by Agnonchik:
> Seems that I have found a discrepancy of this implementation from the 
> original Yehuda Koren's SVD++ algorithm.
> line 140:
> double denominator = Math.sqrt(itemsByUser.size());
> should be
> double denominator = Math.sqrt(itemsByUser.get(u).size());
> line 164:
> double denominator = Math.sqrt(itemsByUser.size());
> should be
> double denominator = Math.sqrt(itemsByUser.get(u).size());
> The sum of y parameters should be normalized by square root of number of 
> items for which user u provided implicit feedback. Am I right?
> Currently, it is normalized by square root of number of users not items.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to