[ 
https://issues.apache.org/jira/browse/MAHOUT-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Schelter updated MAHOUT-1173:
---------------------------------------

    Attachment: mahout-checkstyle.xml

I recreated the checkstyle file. I started with the default file for Sun's code 
conventions and modified it to fit to our codebase.

I added custom things like allowing variable names to start with uppercase 
letters (which is sometimes necessary for keeping mathematical notations found 
in papers) and tried to fit the rules to our codebase.

Checkstyle gives a lot of warnings, but most of them are due to easy to fix 
things like trailing whitespaces in files or indentation issues.

It would great if committers could have a look at the rules and give their ok. 
I tried to make sure that we get a clean up but don't change our coding style.

If there is agreement about the rules, I would suggest to fix all issues in one 
big commit here.
 

                
> Reactivate checkstyle 
> ----------------------
>
>                 Key: MAHOUT-1173
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1173
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Sebastian Schelter
>            Assignee: Sebastian Schelter
>         Attachments: mahout-checkstyle.xml
>
>
> I would like to reactivate checkstyle in our build. IMHO we should not make 
> it fail on checkstyle errors at the moment (anyone disagree on this?).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to