If it's ok with other folks I'd love to participate in code reviews. Having never used review board before do we need a separate review board account outside of JIRA or confluence?
> From: [email protected] > Date: Tue, 9 Apr 2013 07:13:34 -0700 > Subject: Re: Code reviews and reviewers > To: [email protected] > > On Tue, Apr 9, 2013 at 5:03 AM, Dan Filimon > <[email protected]>wrote: > > > Thanks Sebastian! > > > > But let's talk about policy. Wouldn't everyone agree that more code reviews > > are a good thing? > > > > Absolutely. > > > > Ideally, everyone does it and becomes familiar with the code base. > > > > So, even though I, for instance wouldn't be able to say much about > > something I haven't worked on, like recommendation systems, a sanity check > > is always good to have. > > Also good for having a cohesive style and ensuring the code is easy to read > > and is adequately documented. > > > > And frankly, it is often not noticed by newcomers that they anybody can > participate in code reviews. > > Also, code reviews are not just about the code being reviewed. As you > read, you are reviewing your own knowledge of the subject at hand. Asking > questions in a review is a great way to learn. > > > > > Right now, it looks like there aren't that many changes going through > > ReviewBoard. Sure, there's JIRA, but for more significant changes? > > > > Any thoughts on what's best to do? > > > > More reviews are all to the better. > > The only question is how to convince lurkers to be brave and try reviewing.
