Robin, Can you make sure that the patches are somewhere that Dan can pick up this work? He is in GMT+2 and is probably about to appear on the scene.
On Sun, Apr 14, 2013 at 9:34 PM, Robin Anil <[email protected]> wrote: > Strike that there are still failures. Investigating. if I cant fix it in > the next hour, I will submit them sometime in the evening tomorrow. > > Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > > > On Sun, Apr 14, 2013 at 11:33 PM, Robin Anil <[email protected]> wrote: > > > Tests pass. Submitting the patches. > > > > Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > > > > > > On Sun, Apr 14, 2013 at 11:17 PM, Robin Anil <[email protected]> > wrote: > > > >> Added a few more tests. Throw NoSuchElementException like Java > >> Collections when iterating past the end. Things look solid, performance > is > >> 2x. All Math tests pass. I am now waiting for the entire test suites to > run > >> before submitting. > >> > >> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > >> > >> > >> On Sun, Apr 14, 2013 at 9:49 PM, Robin Anil <[email protected]> > wrote: > >> > >>> I am not sure what I did. But removing Guava Abstract iterator actually > >>> sped up the dot, cosine, euclidean by another 60%. Things are now 2x > faster > >>> than trunk. While also correcting the behavior (I hope) > >>> > >>> > >>> > https://docs.google.com/spreadsheet/ccc?key=0AhewTD_ZgznddGFQbWJCQTZXSnFULUYzdURfWDRJQlE#gid=1 > >>> > >>> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > >>> > >>> > >>> On Sun, Apr 14, 2013 at 8:56 PM, Robin Anil <[email protected] > >wrote: > >>> > >>>> Also note that this is code gen, I have to create > Element$keyType$Value > >>>> for each and every combination not just int double. and also update > all > >>>> callers to user ElementIntDouble instead of Element. Is it worth it ? > >>>> > >>>> Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > >>>> > >>>> > >>>> On Sun, Apr 14, 2013 at 8:46 PM, Ted Dunning <[email protected] > >wrote: > >>>> > >>>>> Collections (no longer colt collections) are now part of mahout math. > >>>>> No > >>>>> need to keep them separate. The lower iterator can reference > >>>>> Vector.Element > >>>>> > >>>>> > >>>>> On Sun, Apr 14, 2013 at 6:24 PM, Robin Anil <[email protected]> > >>>>> wrote: > >>>>> > >>>>> > I would have loved to but Element is a sub interface in Vector. If > >>>>> we want > >>>>> > to keep colt collections separate we have to keep this separation. > >>>>> > > >>>>> > >>>> > >>>> > >>> > >> > > >
