Minor variance +-5% is seen in JVM, so I usually dont pay much attention to those. Try to kill all active cpu using processes before running these. I am going to patch your diff in to get a before after benchmark on my laptop.
------ Robin Anil On Sat, Apr 20, 2013 at 11:44 AM, Dan Filimon <[email protected]>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10669/ > Review request for mahout, Ted Dunning, Sebastian Schelter, and Robin > Anil. > By Dan Filimon. > > *Updated April 20, 2013, 4:44 p.m.* > Description > > This patch contains code cleaning up AbstractVector and making the operations > as fast as possible while still having a high level interface. > > The main changes are in AbstractVector as well as new methods in > DoubleDoubleFunction. > > Testing > > The vectors test pass but it's likely that the patch in it's current state is > broken as other, unrelated tests (BallKMeans...) are failing. > Also, my Hadoop conf is broken so I didn't run all the core tests. Anyone? > > I can't seem to find the bug, so _please_ have a closer look. It's still a > work in progress. > > The benchmarks seem comparable (although there are some jarring diferences – > Minkowski distance seems a lot slower in new-dan-1 than old-trunk-2). It may > be however that this is just variance due to the load of the machine at the > time. I'm having trouble interpreting the benchmarks in general, so anyone > who could give me a hand is more than welcome. > > Diffs > > - math/src/main/java/org/apache/mahout/math/AbstractMatrix.java > (e12aa38) > - math/src/main/java/org/apache/mahout/math/AbstractVector.java > (090aa7a) > - math/src/main/java/org/apache/mahout/math/Centroid.java (0c42196) > - math/src/main/java/org/apache/mahout/math/ConstantVector.java > (51d67d4) > - math/src/main/java/org/apache/mahout/math/DelegatingVector.java > (12220d4) > - math/src/main/java/org/apache/mahout/math/DenseVector.java (41c356b) > - > math/src/main/java/org/apache/mahout/math/FileBasedSparseBinaryMatrix.java > (094003b) > - math/src/main/java/org/apache/mahout/math/MatrixSlice.java (7f79c96) > - math/src/main/java/org/apache/mahout/math/MatrixVectorView.java > (af70727) > - math/src/main/java/org/apache/mahout/math/NamedVector.java (4b7a41d) > - math/src/main/java/org/apache/mahout/math/OrderedIntDoubleMapping.java > (650d82d) > - math/src/main/java/org/apache/mahout/math/PermutedVectorView.java > (d1ea93a) > - math/src/main/java/org/apache/mahout/math/RandomAccessSparseVector.java > (6f85692) > - > math/src/main/java/org/apache/mahout/math/SequentialAccessSparseVector.java > (21982f9) > - math/src/main/java/org/apache/mahout/math/Vector.java (2f8b417) > - math/src/main/java/org/apache/mahout/math/VectorView.java (add2a60) > - math/src/main/java/org/apache/mahout/math/WeightedVector.java > (06fbd05) > - > math/src/main/java/org/apache/mahout/math/function/DoubleDoubleFunction.java > (82b350a) > - math/src/main/java/org/apache/mahout/math/function/Functions.java > (eb2e42f) > - math/src/main/java/org/apache/mahout/math/function/PlusMult.java > (60587b1) > - math/src/main/java/org/apache/mahout/math/function/TimesFunction.java > (8ab0bb1) > - math/src/main/java/org/apache/mahout/math/jet/math/Constants.java > (53535d6) > - math/src/test/java/org/apache/mahout/math/AbstractVectorTest.java > (2b11199) > - > math/src/test/java/org/apache/mahout/math/TestSequentialAccessSparseVector.java > (5fbcdd0) > - math/src/test/java/org/apache/mahout/math/VectorTest.java (d6d554b) > > View Diff <https://reviews.apache.org/r/10669/diff/> >
