Before I forget. One more thing 7. Add test harness for functions. So if say a function says isLikeLeftPlus() == true. Take random values from Double Range -inf to +inf to make sure its true for those values.
Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. On Tue, Apr 30, 2013 at 2:19 PM, Robin Anil <[email protected]> wrote: > Tried with your changes pulled in. Other than maybe variance due to my > process state (of my macbook). The benchmarks that had the regression don't > show any marked improvement. > > See column Y > > https://docs.google.com/spreadsheet/ccc?key=0AochdzPoBmWodG9RTms1UG40YlNQd3ByUFpQY0FLWmc#gid=8 > > Robin Anil | Software Engineer | +1 312 869 2602 | Google Inc. > > > On Tue, Apr 30, 2013 at 12:55 PM, Dan Filimon <[email protected] > > wrote: > >> Robin, regarding Times, I think it should work the same now. I changed >> the swapping condition in AbstractVector.times to something more readable. >> As for norm1, it looks like it's exactly the same. I don't see what's >> causing the slowdown other than the indirection. >> >> Could you please try the new version on your machine? >> > >
