[
https://issues.apache.org/jira/browse/MAHOUT-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675285#comment-13675285
]
Sean Owen commented on MAHOUT-1211:
-----------------------------------
Yes this is why I think "false" is appropriate for writers, for sure. For
readers, I don't know. Your logic is sound but there's no reason to believe
this is the logic implementations follow. What is un-recoverable about a
failure to close a readable stream? I can't figure out what harm you can
plausibly assume it would do to proceed. Either way it's a guess, I guess. I
could see the argument for being conservative and not closing quietly, ever.
Then, these methods should just be calling close() directly.
> Replace deprecated Closables.closeQuietly calls
> -----------------------------------------------
>
> Key: MAHOUT-1211
> URL: https://issues.apache.org/jira/browse/MAHOUT-1211
> Project: Mahout
> Issue Type: Improvement
> Reporter: Stevo Slavic
> Assignee: Ted Dunning
> Priority: Minor
> Fix For: 0.8
>
> Attachments: MAHOUT-1211.patch
>
>
> Deprecated Guava {{Closables.closeQuietly}} API has to be replaced, it's
> usage is a code smell, and that method is scheduled to be removed from Guava
> 16.0.
> See [this
> discussion|https://code.google.com/p/guava-libraries/issues/detail?id=1118]
> for more info.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
