[ 
https://issues.apache.org/jira/browse/MAHOUT-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776930#comment-13776930
 ] 

Stevo Slavic commented on MAHOUT-1342:
--------------------------------------

Patch is applied, thanks [~mpercy] for providing it.

Btw, I'm finding [apache-rat-plugin check-mojo 
docs|http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html] to be 
confusing.
For parameter {{excludes}} docs state:
{quote}
Specifies files, which are excluded in the report. By default, no files are 
excluded.
{quote}
While for parameter {{useDefaultExcludes}} of the same mojo docs state:
{quote}
Whether to use the default excludes when scanning for files. The default 
excludes are:
meta data files for version control systems
temporary files used by Maven, see useMavenDefaultExcludes
configuration files for Eclipse, see useEclipseDefaultExcludes
configuration files for IDEA, see useIdeaDefaultExcludes

Default value is: true.
User property is: rat.useDefaultExcludes.
{quote}

If {{useDefaultExcludes}} being true by default was respected, I expect that we 
would not have to configure excludes for svn, maven, eclipse and idea files. 
Also I expect that specifying (additional) {{excludes}} should not be turning 
off {{useDefaultExcludes}}.
                
> Exclude .git/**, Eclipse, and .patch files from Rat check
> ---------------------------------------------------------
>
>                 Key: MAHOUT-1342
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1342
>             Project: Mahout
>          Issue Type: Improvement
>          Components: build
>            Reporter: Mike Percy
>            Assignee: Stevo Slavic
>            Priority: Minor
>             Fix For: 0.9
>
>         Attachments: MAHOUT-1342.patch
>
>
> Simple patch to exclude the .git directory, along with Eclipse working 
> directory files and patch files from the Rat check so that it can be run in a 
> developer environment with those impurities present.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to