[ 
https://issues.apache.org/jira/browse/MAHOUT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788645#comment-13788645
 ] 

Stevo Slavic commented on MAHOUT-1343:
--------------------------------------

Since proposed {{JsonClusterWriter}} doesn't make use of {{subString}} (just 
like existing {{CSVClusterWriter}}), consider omitting it from class, 
constructor, and constructor call.
There is some trailing whitespace introduced in new JSON case in 
{{ClusterDumper}}, and a tiny indentation error in unit test.
Apart from these tiny bits, patch looks OK to me.

> JSON output format for clusterdumper
> ------------------------------------
>
>                 Key: MAHOUT-1343
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1343
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Clustering, Integration
>    Affects Versions: 0.8
>            Reporter: Telvis Calhoun
>              Labels: dumper
>             Fix For: 0.9
>
>         Attachments: clusterdump-example.json, MAHOUT-1343.patch
>
>
> This patch adds JSON output format to the clusterdump utility. Each cluster 
> is represented as a JSON-encoded line. The command is something like:
> >> mahout clusterdump -d dictionary -dt text -i clusters/clusters-2-final -p 
> >> clusters/clusteredPoints -n 10 -o clusterdump.json -of JSON



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to