[
https://issues.apache.org/jira/browse/MAHOUT-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830478#comment-13830478
]
Hudson commented on MAHOUT-1317:
--------------------------------
SUCCESS: Integrated in Mahout-Quality #2330 (See
[https://builds.apache.org/job/Mahout-Quality/2330/])
MAHOUT-1317:Clarify some of the messages in Preconditions.checkArgument
(smarthi: rev 1544673)
* /mahout/trunk/CHANGELOG
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/SolveExplicitFeedbackMapper.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/als/SolveImplicitFeedbackMapper.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/similarity/item/ItemSimilarityJob.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/SamplingLongPrimitiveIterator.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/common/WeightedRunningAverage.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/GenericRecommenderIRStatsEvaluator.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/IRStatisticsImpl.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/SamplingCandidateItemsStrategy.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/similarity/GenericItemSimilarity.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/similarity/GenericUserSimilarity.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/data/DataConverter.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/data/DataLoader.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/data/Dataset.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/mapreduce/partial/Step1Mapper.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/df/mapreduce/partial/TreeID.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/classifier/naivebayes/training/WeightsMapper.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/kmeans/RandomSeedGenerator.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/streaming/mapreduce/StreamingKMeansDriver.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/common/iterator/SamplingIterator.java
* /mahout/trunk/core/src/main/java/org/apache/mahout/math/Varint.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/math/hadoop/similarity/cooccurrence/RowSimilarityJob.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/math/neighborhood/BruteSearch.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/math/neighborhood/FastProjectionSearch.java
*
/mahout/trunk/core/src/main/java/org/apache/mahout/math/neighborhood/ProjectionSearch.java
*
/mahout/trunk/core/src/test/java/org/apache/mahout/math/neighborhood/SearchQualityTest.java
*
/mahout/trunk/examples/src/main/java/org/apache/mahout/cf/taste/example/kddcup/KDDCupDataModel.java
*
/mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/impl/model/cassandra/CassandraDataModel.java
*
/mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/impl/model/mongodb/MongoDBDataModel.java
*
/mahout/trunk/integration/src/main/java/org/apache/mahout/utils/SplitInput.java
*
/mahout/trunk/integration/src/main/java/org/apache/mahout/utils/vectors/lucene/LuceneIterator.java
*
/mahout/trunk/math/src/main/java/org/apache/mahout/math/CholeskyDecomposition.java
*
/mahout/trunk/math/src/main/java/org/apache/mahout/math/als/AlternatingLeastSquaresSolver.java
*
/mahout/trunk/math/src/main/java/org/apache/mahout/math/random/ChineseRestaurant.java
* /mahout/trunk/math/src/main/java/org/apache/mahout/math/random/Empirical.java
> Clarify some of the messages in Preconditions.checkArgument
> -----------------------------------------------------------
>
> Key: MAHOUT-1317
> URL: https://issues.apache.org/jira/browse/MAHOUT-1317
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.9
> Reporter: BFL
> Assignee: Suneel Marthi
> Priority: Minor
> Fix For: 0.9
>
> Attachments: MAHOUT-1317.patch, MAHOUT-1317.patch
>
>
> In experimenting with things, I was getting some errors from
> RowSimilarityJob, that in looking at the source I realized were a little
> incomplete as to what the true issue was. In this case, they were of the
> form:
> Preconditions.checkArgument(maxSimilaritiesPerRow > 0, "Incorrect maximum
> number of similarities per row!");
> Here, it is known that the actual issue is that the parameter must be zero
> (or negative), not just that it's "incorrect", and a (trivial) change to the
> error message might save some folks some time... especially newbies like
> myself.
> A quick grep of the code showed a few more cases like that across the code
> base that would be (apparently) easy to fix and maybe save folks time when
> they get the relevant error.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
