[
https://issues.apache.org/jira/browse/MAHOUT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830784#comment-13830784
]
Suneel Marthi edited comment on MAHOUT-1345 at 11/23/13 11:33 PM:
------------------------------------------------------------------
Dawid/Sean,
I updated the patch with Sean's comments and also upgraded Lucene to 4.5.1 (per
Dawid's earlier comment). That seems to have done it. I am seeing this one test
below (from lucene2seq) that's failing. I haven't had time to look at it yet,
will do so later today.
Upgrading Lucene to 4.5.1 seems to have fixed the other Lucene test failures on
Mac OS 10.8.
{Code}
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.74 sec <<<
FAILURE! - in org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest
testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
Time elapsed: 5.295 sec <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 2 threads leaked from TEST
scope at
testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest):
1) Thread[id=17, name=communication thread, state=TIMED_WAITING,
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
at java.lang.Object.wait(Native Method)
at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
at java.lang.Thread.run(Thread.java:695)
2) Thread[id=18, name=communication thread, state=TIMED_WAITING,
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
at java.lang.Object.wait(Native Method)
at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
at java.lang.Thread.run(Thread.java:695)
at
__randomizedtesting.SeedInfo.seed([1461D3656229CEF6:754E609B0F93CC7]:0)
{Code}
was (Author: smarthi):
Dawid/Sean,
I updated the patch with Sean's comments and also upgraded Lucene to 4.5.1 (per
Dawid's earlier comment). That seems to have done it. I am seeing this one test
below (from lucene2seq) that's failing. I haven't had time to look at it yet,
will do so later today.
Upgrading Lucene to 4.5.1 seems to have fixed the Lucene test failures on Mac
OS 10.8.
{Code}
Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.74 sec <<<
FAILURE! - in org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest
testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest)
Time elapsed: 5.295 sec <<< ERROR!
com.carrotsearch.randomizedtesting.ThreadLeakError: 2 threads leaked from TEST
scope at
testRunInvalidQuery(org.apache.mahout.text.SequenceFilesFromLuceneStorageDriverTest):
1) Thread[id=17, name=communication thread, state=TIMED_WAITING,
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
at java.lang.Object.wait(Native Method)
at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
at java.lang.Thread.run(Thread.java:695)
2) Thread[id=18, name=communication thread, state=TIMED_WAITING,
group=TGRP-SequenceFilesFromLuceneStorageDriverTest]
at java.lang.Object.wait(Native Method)
at org.apache.hadoop.mapred.Task$TaskReporter.run(Task.java:658)
at java.lang.Thread.run(Thread.java:695)
at
__randomizedtesting.SeedInfo.seed([1461D3656229CEF6:754E609B0F93CC7]:0)
{Code}
> Enable randomised testing for all Mahout modules
> ------------------------------------------------
>
> Key: MAHOUT-1345
> URL: https://issues.apache.org/jira/browse/MAHOUT-1345
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Isabel Drost-Fromm
> Priority: Minor
> Fix For: 0.9
>
> Attachments: MAHOUT-1345.diff
>
>
> When enabling randomised testing for all modules I found a few tests became
> unstable or even fail deterministically due to lingering threads. The
> attached patch:
> * defines the randomised testing dependency in our parent pom
> * re-uses said dependencies in all depending modules (makes upgrading easier
> as the version number needs to be changed in just one place)
> * adds several code changes that fixed the failures due to lingering threads
> for me on my machine. I'd greatly appreciate input a) from those who wrote
> the respective code and b) others who ran the tests with these changes to
> make sure there are no other tests that suffer from the same issues.
> Warning: I touched quite a few bits and pieces I'm not intimately familiar
> with over the last few weeks (whenever I had a few spare minutes) - second
> pair of eyes needed.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
