[ 
https://issues.apache.org/jira/browse/MAHOUT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manoj Awasthi updated MAHOUT-1385:
----------------------------------

    Status: Patch Available  (was: Open)

I think argument originalForm has to be changed to byte[] and didn't fully 
understand [~baunz]'s comment on why it shouldn't be. Submitting a patch. Also 
fixed the test for continuousValueEncoder and made it a subclass of 
MahoutTestCase so that it can be executed as a JUnit test.  

> Caching Encoders don't cache
> ----------------------------
>
>                 Key: MAHOUT-1385
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1385
>             Project: Mahout
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Johannes Schulte
>            Priority: Minor
>         Attachments: MAHOUT-1385-test.patch, MAHOUT-1385.patch
>
>
> The Caching... line of encoders contains code of caching the hash code terms 
> added to the vector. However, the method "hashForProbe" inside this classes 
> is never called as the signature has String for the parameter original form 
> (instead of byte[] like other encoders).
> Changing this to byte[] however would lose the java String internal caching 
> of the Strings hash code , that is used as a key in the cache map, triggering 
> another hash code calculation.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to