[ 
https://issues.apache.org/jira/browse/MAHOUT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983043#comment-13983043
 ] 

Sean Owen commented on MAHOUT-1310:
-----------------------------------

Some small suggestions:


If you want to make a File representing a file in a subdirectory represented by 
a File, you can just...

File dir = ...;
File file = new File(dir, ...);

Clean and no platform-dependence.


For detecting Windows, try SystemUtils, from Commons Lang, which is already a 
dependency.
https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/SystemUtils.html

SystemUtils.IS_OS_WINDOWS


Is that change to add -Djava.library.path going to be OK on non-Windows 
systems? it has a backslash.

> Mahout support windows
> ----------------------
>
>                 Key: MAHOUT-1310
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1310
>             Project: Mahout
>          Issue Type: Task
>    Affects Versions: 0.9
>         Environment: Operation system: Windows
>            Reporter: Sergey Svinarchuk
>            Assignee: Sergey Svinarchuk
>              Labels: patch
>             Fix For: 1.0
>
>         Attachments: 1310-2.patch, 1310.patch, Mahout_build_on_winodws.PNG
>
>
> Update mahout for build it on Windows with hadoop 2 and add bin/mahout.cmd



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to