I've upload the patch under mahout-git repository. I couldn't put it under mahout - it gives me 'No valid separator after the filename was found in the diff header' (I use git instead of svn)
On 5 May 2014 01:23, Sebastian Schelter (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/MAHOUT-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989011#comment-13989011] > > Sebastian Schelter commented on MAHOUT-1428: > -------------------------------------------- > > Dodi, > > could you upload your patch to reviewboard at https://reviews.apache.org/? > This will make it easier to discuss. > > > Recommending already consumed items > > ----------------------------------- > > > > Key: MAHOUT-1428 > > URL: https://issues.apache.org/jira/browse/MAHOUT-1428 > > Project: Mahout > > Issue Type: Bug > > Components: Collaborative Filtering > > Affects Versions: 1.0 > > Reporter: Mario Levitin > > Labels: easyfix > > Fix For: 1.0 > > > > Attachments: MAHOUT-1428.patch > > > > > > Mahout does not recommend items which are already consumed by the user. > > For example, > > In the getAllOtherItems method of GenericUserBasedRecommender class > there is the following line > > possibleItemIDs.removeAll(dataModel.getItemIDsFromUser(theUserID)); > > which removes user's items from the possibleItemIDs to prevent these > items from being recommended to the user. This is ok for many > recommendation cases but for many other cases it is not. > > The Recommender classes (I mean all of them, NN-based and SVD-based as > well as hadoop and non-hadoop versions) might have a parameter for this for > excluding or not excluding user items in the returned recommendations. > > > > -- > This message was sent by Atlassian JIRA > (v6.2#6252) > -- Best Regards, Dodi Amar Hakim
