On Fri, May 16, 2014 at 10:16 AM, Pat Ferrel <[email protected]> wrote:
> Agree 100% but there is seems to be an extra level of indirection here. > > 1) do your work in your personal github repo, probably using a branch > Exactly. > 2) issue a pull request to ??? the github Mahout repo or Apache Mahout git > repo? > To the github Mahout mirror. Otherwise, yes. > 3) respond to the request somewhere to make sure the merge goes well. > exactly. > It would be nice if we only had to deal with github imo. They will trigger > a Jenkins build on repo changes. > Well... yes. It would be nice to use the pretty green button on the github site, but it isn't much more work to do the merges manual. For merges that are clean, there are 3 or 4 commands required to merge the PR and github provides them. Doing the JIRA is additional effort. > > On May 15, 2014, at 3:33 PM, Ted Dunning <[email protected]> wrote: > > On Fri, May 9, 2014 at 4:17 PM, Pat Ferrel <[email protected]> wrote: > > > But pull requests would just be for contributors, right? Committers > should > > be able to push to the master directly, right? > > > > Not necessarily. Pull requests are so lovely nice to work with no matter > who you are. > > I can easily imagine using them myself for a long-lived change. > >
