[
https://issues.apache.org/jira/browse/MAHOUT-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061368#comment-14061368
]
ASF GitHub Bot commented on MAHOUT-1595:
----------------------------------------
Github user tdunning commented on the pull request:
https://github.com/apache/mahout/pull/25#issuecomment-48969184
I don't think that this goes quite far enough.
For instance, if you take a row view of a sparse row matrix, you can
actually have a really truly sparse iterator. For other horizontal strides you
can have something like that. This may already be handled by our current
sparse matrices.
For vertical strides, there may not be anything that is all that much
better than what this delta provides.
Does this patch actually make things faster? More than just tightening the
inner loop would explain?
> iterateNonZero() is broken in MatrixVectorView
> ----------------------------------------------
>
> Key: MAHOUT-1595
> URL: https://issues.apache.org/jira/browse/MAHOUT-1595
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Anand Avati
>
> iterateNonZero() in MatrixVectorView is broken and behaves like a normal
> iterator, over all elements.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
