On Tue, Jul 15, 2014 at 12:45 PM, Pat Ferrel <[email protected]> wrote:
> I appreciate the thoughts. > > I don’t change nrow it is still a lazy val. I change _nrow, which is a var > and is used to calculate nrow when it is needed. The only thing run on them > is the CheckpointedDrmSpark constructor. The class exists to guarantee the > drm is pinned down and _nrow is changed after construction but before any > math is done on it. Changing _nrow may be safe on a CheckpointedDrmSpark > but the question is why I’ll put it up on a PR. > > btw I was thinking of calling the method > CheckpointedDrmSpark#addEmptyRows, which since it’s sparse will just change > _nrow and will flag the purpose of the method not to mention it avoids the > question about reducing the number of rows. I would prefer a new rbind() operator instead of addEmptyRows() method. Just feels more consistent. Thanks
