On Fri, Sep 12, 2014 at 11:56 AM, Anand Avati <[email protected]> wrote:
> On Fri, Sep 12, 2014 at 11:30 AM, Dmitriy Lyubimov <[email protected]> > wrote: > > > Actually, as it stands, collect doesn't support labels (either as keys or > > Named Vectors). > > > > There are 2 considerations: > > (1) I chose to ignore any use of NamedVectors in DRM since DRM already > has > > row keys, and two different sources have been creating ambiguity of > > interpretation, so i tailored all the algorithms on Spark to use keys > (not > > named vectors). > > > > (2) the reason why row keys are not translated to row bindings is because > > row keys are not necessarily strings, so translating them would require > > correct support of toString() transformation on any possible key. > > > > (3) I all drm collect cases i ever encountered, i never had any use for > > keys. > > > > Aside from (2) and (3) there's not much reason not to do it as described > in > > (2). > > > > > It seems (2) is the way things are already. collect() in sparkbindings is > already fetching non-int keys, toString'ing them, and calling > m.setRowLabelBindings. If not, it would be inexplicable how one of the > string keys became available when Andrew attempted the getRowLabelBindings. > It does? Really? Gosh. it's been two years since i've been writing this code. I can't remember everything :) > It is still unexplained why only 1 entry made it, and not all. > > Thanks >
