[ 
https://issues.apache.org/jira/browse/MAHOUT-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237328#comment-14237328
 ] 

ASF GitHub Bot commented on MAHOUT-1493:
----------------------------------------

Github user avati commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/32#discussion_r21430646
  
    --- Diff: h2o/src/main/java/org/apache/mahout/h2obindings/H2OHelper.java ---
    @@ -327,8 +327,9 @@ public static H2ODrm drmFromMatrix(Matrix m, int 
minHint, int exactHint) {
           labels = frame.anyVec().makeZero();
           Vec.Writer writer = labels.open();
           Map<Integer,String> rmap = reverseMap(map);
    -
    -      for (long r = 0; r < m.rowSize(); r++) {
    +      // TODO: fix BUG here... h20 water.fvec.Vec does not accept String 
values
    +      // TODO: need a new distributed data structure for storing String 
keys.
    +      for (int r = 0; r < m.rowSize(); r++) {
             writer.set(r, rmap.get(r));
    --- End diff --
    
    Argh, the formatting got messed up. Please replace "writer.set(r, 
rmap.get(r));" with "labels.chunkForRow(r).set(r, rmap.get(r));"


> Port Naive Bayes to the Spark DSL
> ---------------------------------
>
>                 Key: MAHOUT-1493
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1493
>             Project: Mahout
>          Issue Type: Bug
>          Components: Classification
>            Reporter: Sebastian Schelter
>            Assignee: Andrew Palumbo
>             Fix For: 1.0
>
>         Attachments: MAHOUT-1493.patch, MAHOUT-1493.patch, MAHOUT-1493.patch, 
> MAHOUT-1493.patch, MAHOUT-1493a.patch
>
>
> Port our Naive Bayes implementation to the new spark dsl. Shouldn't require 
> more than a few lines of code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to