[
https://issues.apache.org/jira/browse/MAHOUT-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394083#comment-14394083
]
ASF GitHub Bot commented on MAHOUT-1638:
----------------------------------------
GitHub user avati opened a pull request:
https://github.com/apache/mahout/pull/99
MAHOUT-1638: implement String equivalent of Vec.makeCons()
Necessary for creating an empty Vec to hold String labels in the
future.
Replace calls to Vec.makeCons with H2OHelper.makeEmptyStrVec()
where the created Vec is used to store label strings.
Also, fix an off-by-one bug in MapBlockHelper
Signed-off-by: Anand Avati <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/avati/mahout MAHOUT-1638
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit 9d892697bd483773f2b75a70045cf66fba4cb91c
Author: Anand Avati <[email protected]>
Date: 2015-04-03T03:53:52Z
MAHOUT-1638: implement String equivalent of Vec.makeCons()
Necessary for creating an empty Vec to hold String labels in the
future.
Replace calls to Vec.makeCons with H2OHelper.makeEmptyStrVec()
where the created Vec is used to store label strings.
Also, fix an off-by-one bug in MapBlockHelper
Signed-off-by: Anand Avati <[email protected]>
----
> H2O bindings fail at drmParallelizeWithRowLabels(...)
> -----------------------------------------------------
>
> Key: MAHOUT-1638
> URL: https://issues.apache.org/jira/browse/MAHOUT-1638
> Project: Mahout
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Andrew Palumbo
> Assignee: Andrew Palumbo
> Priority: Blocker
> Labels: DSL, h2o, scala
> Fix For: 0.10.1
>
>
> The H2OHelper.drmFromMatrix(...) function fails when trying to write row
> label String keys to a water.fvec.Vec.:
> {code:java}
> java.lang.IllegalArgumentException: Not a String
> at water.fvec.Chunk.set_impl(Chunk.java:507)
> at water.fvec.Chunk.set0(Chunk.java:469)
> at water.fvec.Chunk.set(Chunk.java:371)
> at water.fvec.Vec$Writer.set(Vec.java:803)
> at org.apache.mahout.h2obindings.H2OHelper.drmFromMatrix(H2OHelper.java:331)
> at
> org.apache.mahout.h2obindings.H2OEngine$.drmParallelizeWithRowLabels(H2OEngine.scala:83)
>
> at
> org.apache.mahout.math.drm.package$.drmParallelizeWithRowLabels(package.scala:67)
> {code}
> This causes an exception when calling drm.drmParallelizeWithRowLabels(...)
> To reproduce, apply [PR#72: Enable Naive Bayes Tests in h2o
> Module|https://github.com/apache/mahout/pull/72] and run:
> {code} $ mvn test
> {code}
> from the h2o module:
> {code:java}
> - NB Aggregator *** FAILED ***
> java.lang.IllegalArgumentException: Not a String
> at water.fvec.Chunk.set_impl(Chunk.java:507)
> at water.fvec.Chunk.set0(Chunk.java:469)
> at water.fvec.Chunk.set(Chunk.java:371)
> at water.fvec.Vec$Writer.set(Vec.java:803)
> at org.apache.mahout.h2obindings.H2OHelper.drmFromMatrix(H2OHelper.java:331)
> at
> org.apache.mahout.h2obindings.H2OEngine$.drmParallelizeWithRowLabels(H2OEngine.scala:83)
>
> at
> org.apache.mahout.math.drm.package$.drmParallelizeWithRowLabels(package.scala:67)
>
> at
> org.apache.mahout.classifier.naivebayes.NBTestBase$$anonfun$2.apply$mcV$sp(NBTestBase.scala:91)
>
> at
> org.apache.mahout.classifier.naivebayes.NBTestBase$$anonfun$2.apply(NBTestBase.scala:70)
>
> at
> org.apache.mahout.classifier.naivebayes.NBTestBase$$anonfun$2.apply(NBTestBase.scala:70)
>
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
