[ 
https://issues.apache.org/jira/browse/MAHOUT-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396115#comment-14396115
 ] 

ASF GitHub Bot commented on MAHOUT-1605:
----------------------------------------

GitHub user avati opened a pull request:

    https://github.com/apache/mahout/pull/107

    MAHOUT-1605: fixes in VisualizerTest

    Support decimal separator of various locales

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/avati/mahout MAHOUT-1605

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mahout/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit c5fe843025e401d9302890f6be3f759185b0fe3b
Author: Frank Rosner <[email protected]>
Date:   2014-08-07T13:48:06Z

    MAHOUT-1605 use more readable variable names and remove obsolete comments
    
    EDIT: rebased to master HEAD, resolved conflicts by [email protected]
    
    Signed-off-by: Anand Avati <[email protected]>

commit f824f0a9528e8d2976acd4bf07935413587d8394
Author: Frank Rosner <[email protected]>
Date:   2014-08-07T14:36:30Z

    MAHOUT-1605 use system dependent decimal separator for expectations
    
    EDIT: rebased to master HEAD, resolved conflicts by [email protected]
    
    Signed-off-by: Anand Avati <[email protected]>

----


> Make VisualizerTest locale independent  
> ----------------------------------------
>
>                 Key: MAHOUT-1605
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1605
>             Project: Mahout
>          Issue Type: Test
>    Affects Versions: 0.9
>            Reporter: Frank Rosner
>            Assignee: Anand Avati
>            Priority: Trivial
>              Labels: legacy
>             Fix For: 0.10.0
>
>
> h5. Problem
> When trying to build Mahout on a machine with a locale that uses a different 
> decimal separator, {{org.apache.mahout.classifier.df.tools.VisualizerTest}} 
> fails because of String assertions that are locale dependent.
> Expected: {{humidity < 77.5 : yes}}
> Actual: {{humidity < 77,5 : yes}}
> h5. Solution
> Make assertions locale independent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to