[
https://issues.apache.org/jira/browse/MAHOUT-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396119#comment-14396119
]
ASF GitHub Bot commented on MAHOUT-1622:
----------------------------------------
Github user smarthi commented on a diff in the pull request:
https://github.com/apache/mahout/pull/106#discussion_r27775370
--- Diff:
mr/src/main/java/org/apache/mahout/cf/taste/impl/similarity/precompute/MultithreadedBatchItemSimilarities.java
---
@@ -26,7 +26,7 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
-import com.google.common.collect.Lists;
+import java.util.ArrayList;
import com.google.common.io.Closeables;
--- End diff --
U should be able to get rid of Closeables too, and replace that with Java 7
try - resources; don't worry about that I'll take care of it. JFyi.
> MultithreadedBatchItemSimilarities outputs incorrect number of similarities.
> ----------------------------------------------------------------------------
>
> Key: MAHOUT-1622
> URL: https://issues.apache.org/jira/browse/MAHOUT-1622
> Project: Mahout
> Issue Type: Bug
> Components: Collaborative Filtering
> Affects Versions: 0.9
> Reporter: Jesse Daniels
> Assignee: Anand Avati
> Priority: Minor
> Labels: legacy
> Fix For: 0.10.0
>
> Attachments: batchSimilarities.patch
>
>
> In some cases the Output class in MultithreadedBatchItemSimilarities does not
> output all of the similarity pairs that it should. It is very possible for
> the number of active workers to go to zero while in the while loop, in which
> case the remaining similarities for the finished workers will not be flushed
> to the output. This is because the while loop is only conditioned on whether
> there are active workers or not. An easy fix is to also check to make sure
> the results structure is not empty. This way both the number of active
> workers must be 0 and the result set must be empty to exit the while loop.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
