[ 
https://issues.apache.org/jira/browse/MAHOUT-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396328#comment-14396328
 ] 

Hudson commented on MAHOUT-1622:
--------------------------------

FAILURE: Integrated in Mahout-Quality #3061 (See 
[https://builds.apache.org/job/Mahout-Quality/3061/])
MAHOUT-1622: MultithreadedBatchItemSimilarities outputs incorrect number of 
similarities, this closes apache/mahout#108 (suneel.marthi: rev 
cd366d17e1d9b4c001b0ffa08864e1ad5d21034d)
* CHANGELOG
* 
mr/src/test/java/org/apache/mahout/cf/taste/impl/similarity/precompute/MultithreadedBatchItemSimilaritiesTest.java
* 
mr/src/main/java/org/apache/mahout/cf/taste/impl/similarity/precompute/MultithreadedBatchItemSimilarities.java


> MultithreadedBatchItemSimilarities outputs incorrect number of similarities.
> ----------------------------------------------------------------------------
>
>                 Key: MAHOUT-1622
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1622
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering
>    Affects Versions: 0.9
>            Reporter: Jesse Daniels
>            Assignee: Anand Avati
>            Priority: Minor
>              Labels: legacy
>             Fix For: 0.10.0
>
>         Attachments: batchSimilarities.patch
>
>
> In some cases the Output class in MultithreadedBatchItemSimilarities does not 
> output all of the similarity pairs that it should. It is very possible for 
> the number of active workers to go to zero while in the while loop, in which 
> case the remaining similarities for the finished workers will not be flushed 
> to the output. This is because the while loop is only conditioned on whether 
> there are active workers or not. An easy fix is to also check to make sure 
> the results structure is not empty. This way both the number of active 
> workers must be 0 and the result set must be empty to exit the while loop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to