[
https://issues.apache.org/jira/browse/MAHOUT-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574982#comment-14574982
]
ASF GitHub Bot commented on MAHOUT-1660:
----------------------------------------
Github user dlyubimov commented on a diff in the pull request:
https://github.com/apache/mahout/pull/135#discussion_r31838736
--- Diff: h2o/src/main/scala/org/apache/mahout/h2obindings/H2OEngine.scala
---
@@ -26,9 +26,13 @@ import org.apache.mahout.math.drm.logical._
import org.apache.mahout.h2obindings.ops._
import org.apache.mahout.h2obindings.drm._
import org.apache.mahout.h2o.common.{Hadoop1HDFSUtil, HDFSUtil}
+import org.apache.mahout.logging._
/** H2O specific non-DRM operations */
object H2OEngine extends DistributedEngine {
+
+ private implicit val log = getLog(H2OEngine.getClass)
--- End diff --
yes it should, in fact. thanks. although it is more about private than
final; private values cannot be neighter changed nor overriden anyway. I am a
bit surprised Scala allows "private final" in the first place.
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
> ----------------------------------------------------------
>
> Key: MAHOUT-1660
> URL: https://issues.apache.org/jira/browse/MAHOUT-1660
> Project: Mahout
> Issue Type: Bug
> Components: spark
> Affects Versions: 0.10.0
> Reporter: Suneel Marthi
> Assignee: Dmitriy Lyubimov
> Priority: Minor
> Fix For: 0.10.2
>
>
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop configuration from
> Context and not ignore it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
