[
https://issues.apache.org/jira/browse/MAHOUT-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582492#comment-14582492
]
ASF GitHub Bot commented on MAHOUT-1660:
----------------------------------------
Github user avati commented on a diff in the pull request:
https://github.com/apache/mahout/pull/135#discussion_r32265450
--- Diff: h2o/src/main/java/org/apache/mahout/h2obindings/drm/H2OBCast.java
---
@@ -118,4 +118,16 @@ private T deserialize(byte buf[]) {
}
return ret;
}
+
+ /**
+ * Stop broadcasting when called on driver side. Release any network
resources.
+ *
+ */
+ @Override
+ public void close() throws IOException {
+
+ // TODO: review this. It looks like it is not really a broadcast
mechanism but rather just a
--- End diff --
Yes, h2o's broadcast is just serialize + multiple unicast (almost like
spark's http based broadcast)
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop conf
> ----------------------------------------------------------
>
> Key: MAHOUT-1660
> URL: https://issues.apache.org/jira/browse/MAHOUT-1660
> Project: Mahout
> Issue Type: Bug
> Components: spark
> Affects Versions: 0.10.0
> Reporter: Suneel Marthi
> Assignee: Dmitriy Lyubimov
> Priority: Minor
> Fix For: 0.10.2
>
>
> Hadoop1HDFSUtil.readDRMHEader should be taking Hadoop configuration from
> Context and not ignore it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
