It doesn't really matter to me if you squash everything or not, whatever is best for you. I can also open several pull requests, although I'm not sure what's the best way of splitting it. Since it certainly will require some additional work, I'd rather have it squashed :)
On 29 September 2015 at 20:10, Dmitriy Lyubimov <[email protected]> wrote: > i think it makes sense to to start splitting this big work into a few pull > requests. > > One inconvenience for you would be if we merge your branch into master, we > will squash it -- so you will have to start off a new PR branch after that. > Is that ok with you? > > On Tue, Sep 29, 2015 at 5:53 AM, Alexey Grigorev < > [email protected]> wrote: > > > Hello everybody, > > > > I was wondering if the pull request ( > > https://github.com/apache/mahout/pull/137) can be accepted? There's > still > > stuff to work on, but I believe this is already in a good shape to > > considered as a first milestone. > > > > Also, my employment at the Technical University of Berlin has come to an > > end, and I won't be able to continue working on Flink integration to > Mahout > > as a paid employee of TU Berlin. However I hope to stay in the community > > and be able to contribute something to Mahout in the future. > > > > Thanks everybody! > > > > Best, > > Alexey > > >
