[
https://issues.apache.org/jira/browse/MAHOUT-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265837#comment-15265837
]
ASF GitHub Bot commented on MAHOUT-1841:
----------------------------------------
GitHub user andrewpalumbo reopened a pull request:
https://github.com/apache/mahout/pull/231
MAHOUT-1841 change UNIFORM_DIVISOR to 2^63 from 2^64
Matrices.SymmetricUniformView is returning numbers on the range of
(-.5,.5). Documentation calls for [1,1).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewpalumbo/mahout uniform
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mahout/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit 1c9bb55676e0247fcbd62313dbbb311db4f922fd
Author: Andrew Palumbo <[email protected]>
Date: 2016-05-01T02:19:24Z
change UNIFORM_DIVISOR to 2^63 from 2^64
----
> Matrices.symmetricUniformView(...) returning values in the wrong range.
> -----------------------------------------------------------------------
>
> Key: MAHOUT-1841
> URL: https://issues.apache.org/jira/browse/MAHOUT-1841
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Affects Versions: 0.12.0
> Reporter: Andrew Palumbo
> Assignee: Suneel Marthi
> Fix For: 0.12.1
>
>
> Per javadocs, {{Matrices.symmetricUniformView(...)}} is meant to return
> values in on the range of [-1,1):
> {code}
> /**
> * Matrix view based on uniform [-1,1) distribution.
> *
> * @param seed generator seed
> */
> public static final Matrix symmetricUniformView(final int rows,
> final int columns,
> int seed) {
> return functionalMatrixView(rows, columns,
> uniformSymmetricGenerator(seed), true);
> }
> {code}
> Ranges being returned now are on (-.5,.5).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
