[jira] [Commented] (MAHOUT-1856) Create a framework for new Mahout Clustering, Classification, and Optimization Algorithms

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAHOUT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837948#comment-15837948
 ] 

ASF GitHub Bot commented on MAHOUT-1856:
----------------------------------------

Github user rawkintrevo commented on a diff in the pull request:

    https://github.com/apache/mahout/pull/246#discussion_r97808310
  
    --- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
    @@ -0,0 +1,52 @@
    +/**
    +  * Licensed to the Apache Software Foundation (ASF) under one
    +  * or more contributor license agreements. See the NOTICE file
    +  * distributed with this work for additional information
    +  * regarding copyright ownership. The ASF licenses this file
    +  * to you under the Apache License, Version 2.0 (the
    +  * "License"); you may not use this file except in compliance
    +  * with the License. You may obtain a copy of the License at
    +  *
    +  * http://www.apache.org/licenses/LICENSE-2.0
    +  *
    +  * Unless required by applicable law or agreed to in writing,
    +  * software distributed under the License is distributed on an
    +  * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +  * KIND, either express or implied. See the License for the
    +  * specific language governing permissions and limitations
    +  * under the License.
    +  */
    +
    +package org.apache.mahout.math.algorithms.regression.tests
    +
    +import org.apache.mahout.math.algorithms.regression.Regressor
    +import org.apache.mahout.math.algorithms.transformer.MeanCenter
    +import org.apache.mahout.math.drm.DrmLike
    +import org.apache.mahout.math.function.Functions.SQUARE
    +import org.apache.mahout.math.scalabindings.RLikeOps._
    +
    +import scala.reflect.ClassTag
    +
    +object FittnessTests {
    +
    +  // https://en.wikipedia.org/wiki/Coefficient_of_determination
    +  def CoefficientOfDetermination[R[K] <: Regressor[K], K](model: R[K],
    +                                              drmTarget: DrmLike[K]): R[K] 
= {
    +    val sumSquareResiduals = model.residuals.assign(SQUARE).sum
    +    val mc = new MeanCenter()
    +    val totalResiduals = mc.fitTransform(drmTarget)
    +    val sumSquareTotal = totalResiduals.assign(SQUARE).sum
    +    val r2 = 1 - (sumSquareResiduals / sumSquareTotal)
    +    model.testResults += ("r2" -> r2)
    +    model.summary += s"\nR^2: ${r2}"
    +    model
    +  }
    +
    +  // https://en.wikipedia.org/wiki/Mean_squared_error
    +  def MeanSquareError[R[K] <: Regressor[K], K](model: R[K]): R[K] = {
    +    val mse = model.residuals.assign(SQUARE).sum / model.residuals.nrow
    --- End diff --
    
    will update this to `safeToNonNegInt(`


> Create a framework for new Mahout Clustering, Classification, and 
> Optimization  Algorithms
> ------------------------------------------------------------------------------------------
>
>                 Key: MAHOUT-1856
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1856
>             Project: Mahout
>          Issue Type: New Feature
>    Affects Versions: 0.12.1
>            Reporter: Andrew Palumbo
>            Assignee: Trevor Grant
>            Priority: Critical
>             Fix For: 0.13.0
>
>
> To ensure that Mahout does not become "A loose bag of algorithms", Create 
> basic traits with funtions common to each class of algorithm. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)