[
https://issues.apache.org/jira/browse/MAHOUT-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886706#comment-15886706
]
ASF GitHub Bot commented on MAHOUT-1882:
----------------------------------------
Github user andrewpalumbo commented on a diff in the pull request:
https://github.com/apache/mahout/pull/290#discussion_r103334831
--- Diff:
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/GPUMMul.scala ---
@@ -242,10 +242,11 @@ object GPUMMul extends MMBinaryFunc {
N.B. This method is horribly inefficent. However there is a
difference between
getNumNonDefaultElements() and getNumNonZeroElements() which we do
not always
have access to. We created MAHOUT-1882 for this.
- val hasElementsA = a.zSum() > 0.0
- val hasElementsB = b.zSum() > 0.0
*/
+ val hasElementsA = a.zSum() > 0.0
+ val hasElementsB = b.zSum() > 0.0
+
// A has a sparse matrix structure of unknown size. We do not want to
--- End diff --
sorry was looking only at one commit.. i see that you already did.
> SequentialAccessSparseVector inerateNonZeros is incorrect.
> ----------------------------------------------------------
>
> Key: MAHOUT-1882
> URL: https://issues.apache.org/jira/browse/MAHOUT-1882
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Affects Versions: 0.12.2
> Reporter: Andrew Palumbo
> Priority: Critical
> Fix For: 0.13.1
>
>
> In {{SequentialAccessSparseVector}} a bug is noted. When Cuonting Non-Zero
> elements {{NonDefaultIterator}} can, under certain circumstances give an
> incorrect iterator of size different from the actual non-zeroCounts.
> {code}
> @Override
> public Iterator<Element> iterateNonZero() {
> // TODO: this is a bug, since nonDefaultIterator doesn't hold to non-zero
> contract.
> return new NonDefaultIterator();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
