rawkintrevo commented on code in PR #500: URL: https://github.com/apache/mahout/pull/500#discussion_r1977924007
########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. -- [ ] Created unit tests where appropriate Review Comment: This should stay ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. -- [ ] Created unit tests where appropriate -- [ ] Added licenses correct on newly added files -- [ ] Assigned JIRA to self -- [ ] Added documentation in scala docs/java docs, and to website -- [ ] Successfully built and ran all unit tests, verified that all tests pass locally. Review Comment: This check should stay. ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] Review Comment: This should stay, but change the link to git issues ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. Review Comment: This should stay- but replace JIRA with Git Issue ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> Review Comment: Drop JIRA, and uncomment this line ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. -- [ ] Created unit tests where appropriate -- [ ] Added licenses correct on newly added files -- [ ] Assigned JIRA to self -- [ ] Added documentation in scala docs/java docs, and to website -- [ ] Successfully built and ran all unit tests, verified that all tests pass locally. +### Changes Made +- [ ] Bug fix +- [ ] New feature +- [ ] Documentation update -If all of these things aren't complete, but you still feel it is -appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the -descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change" +### Breaking Changes +<!-- Does this PR introduce a breaking change? --> +- [ ] Yes +- [ ] No -Does this change break earlier versions? +### Testing & Verification +<!-- Describe how you tested the changes. --> +- [ ] Unit tests added +- [ ] Manually tested -Is this the beginning of a larger project for which a feature branch should be made? +### Checklist +- [ ] The title follows the format "MAHOUT-XXXX Brief Description" +- [ ] JIRA issue is created Review Comment: Change JIRA to Git ########## .github/ISSUE_TEMPLATE/documentation_issue.md: ########## @@ -0,0 +1,19 @@ +--- +name: "Documentation Issue" +about: "Report issues related to documentation" +title: "[Docs] " +labels: ["documentation"] +assignees: [] +--- + +### Description +<!-- What is unclear, incorrect, or missing? --> + +### Location of the Issue +<!-- Provide links or file paths where the issue exists. --> Review Comment: uncomment all of these (i'm not making a comment per line, but that is what I'm saying) ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. -- [ ] Created unit tests where appropriate -- [ ] Added licenses correct on newly added files -- [ ] Assigned JIRA to self -- [ ] Added documentation in scala docs/java docs, and to website -- [ ] Successfully built and ran all unit tests, verified that all tests pass locally. +### Changes Made +- [ ] Bug fix +- [ ] New feature +- [ ] Documentation update -If all of these things aren't complete, but you still feel it is -appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the -descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change" +### Breaking Changes +<!-- Does this PR introduce a breaking change? --> +- [ ] Yes +- [ ] No -Does this change break earlier versions? +### Testing & Verification +<!-- Describe how you tested the changes. --> Review Comment: uncomment ########## .github/ISSUE_TEMPLATE/feature_request.md: ########## @@ -0,0 +1,22 @@ +--- +name: "Feature Request" +about: "Suggest a new feature" +title: "[Feature] " +labels: ["enhancement"] +assignees: [] +--- + +### Summary +<!-- A brief description of the feature. --> Review Comment: again, uncomment these ########## website/_includes/sidebar.html: ########## @@ -35,9 +35,8 @@ [<a href="https://www.slideshare.net/slideshow/qumat_-apache-mahout-s-quantum-computing-interface-pptx/272300949"; target="_blank">Slides</a>] </li> <li> - FOSDEM 2025, Brussels Belgium - <!--a href="https://www.youtube.com/watch?v=tgFaUL1wYhY"; target="_blank"--> - Introducing Qumat! - <!--/a--> + FOSDEM 2025, Brussels Belgium - <a href="https://mirrors.dotsrc.org/fosdem/2025/k4401/fosdem-2025-5298-introducing-qumat-an-apache-mahout-joint-.av1.webm"; target="_blank">Introducing Qumat!</a> Review Comment: I'm not sure what is happening here, but this isn't related to the PR described ########## .github/ISSUE_TEMPLATE/documentation_issue.md: ########## @@ -0,0 +1,19 @@ +--- +name: "Documentation Issue" +about: "Report issues related to documentation" +title: "[Docs] " +labels: ["documentation"] +assignees: [] +--- + +### Description +<!-- What is unclear, incorrect, or missing? --> Review Comment: A lot of good notes, here, but uncomment these lines. ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> Review Comment: Uncomment. I would like to see multiple PR templates, but we can make that a follow on issue ########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -1,21 +1,27 @@ -### Purpose of PR: -Please give a short description of what this PR is for. +### Purpose of PR +<!-- Describe what this PR does. --> +### Linked Issues +<!-- Add links to related issues or JIRA tickets. --> +- Fixes MAHOUT-XXXX +- Related to #123 -### Important ToDos -Please mark each with an "x" -- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/] -- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. -- [ ] Created unit tests where appropriate -- [ ] Added licenses correct on newly added files -- [ ] Assigned JIRA to self -- [ ] Added documentation in scala docs/java docs, and to website -- [ ] Successfully built and ran all unit tests, verified that all tests pass locally. +### Changes Made +- [ ] Bug fix +- [ ] New feature +- [ ] Documentation update -If all of these things aren't complete, but you still feel it is Review Comment: Add something here about making it a draft pr (github's updated version of what this is describing) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mahout.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
