rawkintrevo commented on code in PR #511: URL: https://github.com/apache/mahout/pull/511#discussion_r1986523819
########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -1,5 +1,9 @@ + + + --- layout: page +--- Review Comment: remove this line ########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -1,5 +1,9 @@ + + + Review Comment: remove these lines ########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -55,11 +59,13 @@ Quantum computing is not just a theoretical concept; it has practical implicatio ## 1.4 Getting Started with Quantum Computing Using `qumat` -To begin your journey into quantum computing, you'll use the `qumat` library, which provides a simple and unified interface for working with quantum circuits across different backends (e.g., Amazon Braket, Cirq, Qiskit). Here's a quick example to get you started: +> **Note:** The `qumat` library does not appear to exist. This section is commented out until a valid implementation is available. Review Comment: inaccurate ########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -55,11 +59,13 @@ Quantum computing is not just a theoretical concept; it has practical implicatio ## 1.4 Getting Started with Quantum Computing Using `qumat` -To begin your journey into quantum computing, you'll use the `qumat` library, which provides a simple and unified interface for working with quantum circuits across different backends (e.g., Amazon Braket, Cirq, Qiskit). Here's a quick example to get you started: +> **Note:** The `qumat` library does not appear to exist. This section is commented out until a valid implementation is available. + +<!-- To begin your journey into quantum computing, you'll use the `qumat` library, which provides a simple and unified interface for working with quantum circuits across different backends (e.g., Amazon Braket, Cirq, Qiskit). Here's a quick example to get you started: --> -```python +<!--```python Review Comment: remove this line ########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -70,16 +76,19 @@ qc.apply_hadamard_gate(0) # Execute the circuit and measure the result result = qc.execute_circuit() -print(result) -``` +print(result) +``` --> In this example, we: * Created a quantum circuit with 1 qubit. * Applied a Hadamard gate to put the qubit into a superposition state. * Measured the qubit to observe the probabilistic outcome. -This is just the beginning! In the next sections, you'll dive deeper into quantum gates, circuits, and algorithms using qumat. +# proposed method, does not yet exist Review Comment: which proposed method? why is this a title? ########## website/quantum-computing-primer/01_introduction/index.md: ########## @@ -70,16 +76,19 @@ qc.apply_hadamard_gate(0) # Execute the circuit and measure the result result = qc.execute_circuit() -print(result) -``` +print(result) +``` --> Review Comment: remove this line ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -3,33 +3,25 @@ layout: page title: Quantum Algorithms --- -# 7. Quantum Algorithms +## 7. Quantum Algorithms Review Comment: why are you adding a hash here? ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -3,33 +3,25 @@ layout: page title: Quantum Algorithms --- -# 7. Quantum Algorithms +## 7. Quantum Algorithms -Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the **Deutsch-Jozsa Algorithm** and **Grover's Algorithm**. We will also provide implementations using the `qumat` library. - ---- +Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the Deutsch-Jozsa Algorithm and Grover's Algorithm. We will also provide implementations using the `qumat` library. Review Comment: removing the bold degrades the document quality. drop this line. ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -3,33 +3,25 @@ layout: page title: Quantum Algorithms --- -# 7. Quantum Algorithms +## 7. Quantum Algorithms -Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the **Deutsch-Jozsa Algorithm** and **Grover's Algorithm**. We will also provide implementations using the `qumat` library. - ---- +Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the Deutsch-Jozsa Algorithm and Grover's Algorithm. We will also provide implementations using the `qumat` library. -## 7.1 Deutsch-Jozsa Algorithm +### 7.1 Deutsch-Jozsa Algorithm Review Comment: again, why are we making all of the headings less prominent? ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -3,33 +3,25 @@ layout: page title: Quantum Algorithms --- -# 7. Quantum Algorithms +## 7. Quantum Algorithms -Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the **Deutsch-Jozsa Algorithm** and **Grover's Algorithm**. We will also provide implementations using the `qumat` library. - ---- +Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the Deutsch-Jozsa Algorithm and Grover's Algorithm. We will also provide implementations using the `qumat` library. -## 7.1 Deutsch-Jozsa Algorithm +### 7.1 Deutsch-Jozsa Algorithm -The Deutsch-Jozsa algorithm is one of the earliest quantum algorithms that -demonstrates the potential of quantum computing. It solves a specific problem -exponentially faster than any classical algorithm. +The Deutsch-Jozsa algorithm is one of the earliest quantum algorithms that demonstrates the potential of quantum computing. It solves a specific problem exponentially faster than any classical algorithm. -### Problem Statement -Given a function $ f: \{0,1\}^n \rightarrow \{0,1\} $, determine whether the -function is **constant** (returns the same value for all inputs) or **balanced** -(returns 0 for half of the inputs and 1 for the other half). +#### Problem Statement -### Quantum Solution Review Comment: undo all of this. ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -50,34 +42,31 @@ qc.apply_cnot_gate(0, 1) qc.apply_hadamard_gate(0) # Measure the first qubit -result = qc.execute_circuit() -print(result) +result = qc.execute_circuit() +print(result) ``` -### Explanation -- If the function is **constant**, the first qubit will always measure as `0`. -- If the function is **balanced**, the first qubit will measure as `1` with high probability. +#### Explanation +- If the function is constant, the first qubit will always measure as `0`. Review Comment: removing the bold degrades the document quality. revert this change please. ########## website/quantum-computing-primer/07_quantum_algorithms/index.md: ########## @@ -3,33 +3,25 @@ layout: page title: Quantum Algorithms --- -# 7. Quantum Algorithms +## 7. Quantum Algorithms -Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the **Deutsch-Jozsa Algorithm** and **Grover's Algorithm**. We will also provide implementations using the `qumat` library. - ---- +Quantum algorithms leverage the unique properties of quantum mechanics, such as superposition and entanglement, to solve problems more efficiently than classical algorithms. In this section, we will explore two fundamental quantum algorithms: the Deutsch-Jozsa Algorithm and Grover's Algorithm. We will also provide implementations using the `qumat` library. -## 7.1 Deutsch-Jozsa Algorithm +### 7.1 Deutsch-Jozsa Algorithm -The Deutsch-Jozsa algorithm is one of the earliest quantum algorithms that -demonstrates the potential of quantum computing. It solves a specific problem -exponentially faster than any classical algorithm. +The Deutsch-Jozsa algorithm is one of the earliest quantum algorithms that demonstrates the potential of quantum computing. It solves a specific problem exponentially faster than any classical algorithm. Review Comment: I'm not sure what has changed here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mahout.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org