rich7420 commented on code in PR #675:
URL: https://github.com/apache/mahout/pull/675#discussion_r2585265447
##########
qdp/qdp-core/src/gpu/encodings/amplitude.rs:
##########
@@ -89,12 +94,15 @@ impl QuantumEncoder for AmplitudeEncoder {
return Err(MahoutError::KernelLaunch(error_msg));
}
- // Block until all work on the device is complete
{
crate::profile_scope!("GPU::Synchronize");
_device
.synchronize()
.map_err(|e| MahoutError::Cuda(format!("CUDA device
synchronize failed: {:?}", e)))?;
+ }
+ } else {
+ // Async Pipeline path for large data
+ Self::encode_async_pipeline(_device, host_data, num_qubits,
state_len, norm, &state_vector)?;
Review Comment:
I think it's right. and need to do. I'll add this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
